Stop renumbering arguments in the expression to interpolate
#4582
+85
−112
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pbrubeck
reviewed
Sep 23, 2025
leo-collins
force-pushed
the
leo/simplify-interpolate
branch
2 times, most recently
from
92645d1 to
aa30bf8
Compare
pbrubeck
reviewed
Oct 2, 2025
pbrubeck
reviewed
Oct 2, 2025
pbrubeck
reviewed
Oct 2, 2025
leo-collins
force-pushed
the
leo/simplify-interpolate
branch
3 times, most recently
from
f8c2318 to
31f1cec
Compare
pbrubeck
reviewed
Oct 14, 2025
pbrubeck
reviewed
Oct 14, 2025
dham
requested changes
Oct 14, 2025
leo-collins
force-pushed
the
leo/simplify-interpolate
branch
from
31f1cec to
cfd3b44
Compare
test -> trial fix hypre-ads
cofunction docstring
fix
leo-collins
force-pushed
the
leo/simplify-interpolate
branch
from
cfd3b44 to
c87fd8e
Compare
dham
requested changes
Nov 4, 2025
leo-collins
changed the title
interpolateinterpolate
|
@connorjward Updated the title and added a description aimed towards users. Is this okay to be merged now? |
connorjward
approved these changes
Nov 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the argument renumbering 0 -> 1 in the primal expression if V is a FunctionSpace. Thus if you want to interpolate an expression containing arguments (for example if you want to assemble the interpolation operator) then you need to use a
TrialFunctioninstead of aTestFunction. Recent UFL changes check the argument numbering and raise an error early to avoid confusion.This is an API change and should be merged after the next release. PR #4572 warns users about this.